Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upevents-mixin@1.2.0 to allow function callbacks in events hash #106
Conversation
bear
added
bug
request
labels
Mar 6, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
lukekarrys
Mar 26, 2015
Contributor
+1
Since we are using ^ in the package.json new installs of of ampersand-view should already be getting the updated events-mixin so this is technically "done" already.
$ npm install ampersand-view
ampersand-view@7.2.0 node_modules/ampersand-view
├── get-object-path@0.0.2
├── matches-selector@1.0.0
├── underscore@1.6.0
├── domify@1.3.2
├── events-mixin@1.2.0 (component-event@0.1.4, delegate-events@1.1.0)
├── ampersand-version@1.0.2 (find-root@0.1.1, through2@0.6.3)
├── ampersand-state@4.4.5 (array-next@0.0.1, key-tree-store@0.1.2, backbone-events-standalone@0.2.2)
├── ampersand-collection-view@1.2.1 (backbone-events-standalone@0.2.6, ampersand-class-extend@1.0.1)
├── component-classes@1.2.4 (component-indexof@0.0.3)
└── ampersand-dom-bindings@3.4.0 (is-array@1.0.1, ampersand-dom@1.4.0, key-tree-store@1.2.0)
|
+1 Since we are using
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
So I think this can be merged, but we dont need to publish. |
added a commit
that referenced
this pull request
Mar 26, 2015
lukekarrys
merged commit 3391761
into
master
Mar 26, 2015
lukekarrys
deleted the
events-mixin@1.2.0
branch
Mar 26, 2015
lukekarrys
referenced this pull request
Mar 26, 2015
Closed
Sensible error should be thrown if the named callback in the event hash is missing. #38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kamilogorek commentedMar 6, 2015
Fixes #37 and #38