Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events-mixin@1.2.0 to allow function callbacks in events hash #106

Merged
merged 1 commit into from
Mar 26, 2015

Conversation

kamilogorek
Copy link
Contributor

Fixes #37 and #38

@lukekarrys
Copy link
Contributor

+1

Since we are using ^ in the package.json new installs of of ampersand-view should already be getting the updated events-mixin so this is technically "done" already.

$ npm install ampersand-view
ampersand-view@7.2.0 node_modules/ampersand-view
├── get-object-path@0.0.2
├── matches-selector@1.0.0
├── underscore@1.6.0
├── domify@1.3.2
├── events-mixin@1.2.0 (component-event@0.1.4, delegate-events@1.1.0)
├── ampersand-version@1.0.2 (find-root@0.1.1, through2@0.6.3)
├── ampersand-state@4.4.5 (array-next@0.0.1, key-tree-store@0.1.2, backbone-events-standalone@0.2.2)
├── ampersand-collection-view@1.2.1 (backbone-events-standalone@0.2.6, ampersand-class-extend@1.0.1)
├── component-classes@1.2.4 (component-indexof@0.0.3)
└── ampersand-dom-bindings@3.4.0 (is-array@1.0.1, ampersand-dom@1.4.0, key-tree-store@1.2.0)

@lukekarrys
Copy link
Contributor

So I think this can be merged, but we dont need to publish.

lukekarrys added a commit that referenced this pull request Mar 26, 2015
events-mixin@1.2.0 to allow function callbacks in events hash
@lukekarrys lukekarrys merged commit 3391761 into master Mar 26, 2015
@lukekarrys lukekarrys deleted the events-mixin@1.2.0 branch March 26, 2015 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events hash cannot contain actual functions
3 participants