New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events-mixin@1.2.0 to allow function callbacks in events hash #106

Merged
merged 1 commit into from Mar 26, 2015

Conversation

Projects
None yet
3 participants
@kamilogorek
Member

kamilogorek commented Mar 6, 2015

Fixes #37 and #38

@bear bear added bug request labels Mar 6, 2015

@lukekarrys

This comment has been minimized.

Show comment
Hide comment
@lukekarrys

lukekarrys Mar 26, 2015

Contributor

+1

Since we are using ^ in the package.json new installs of of ampersand-view should already be getting the updated events-mixin so this is technically "done" already.

$ npm install ampersand-view
ampersand-view@7.2.0 node_modules/ampersand-view
├── get-object-path@0.0.2
├── matches-selector@1.0.0
├── underscore@1.6.0
├── domify@1.3.2
├── events-mixin@1.2.0 (component-event@0.1.4, delegate-events@1.1.0)
├── ampersand-version@1.0.2 (find-root@0.1.1, through2@0.6.3)
├── ampersand-state@4.4.5 (array-next@0.0.1, key-tree-store@0.1.2, backbone-events-standalone@0.2.2)
├── ampersand-collection-view@1.2.1 (backbone-events-standalone@0.2.6, ampersand-class-extend@1.0.1)
├── component-classes@1.2.4 (component-indexof@0.0.3)
└── ampersand-dom-bindings@3.4.0 (is-array@1.0.1, ampersand-dom@1.4.0, key-tree-store@1.2.0)
Contributor

lukekarrys commented Mar 26, 2015

+1

Since we are using ^ in the package.json new installs of of ampersand-view should already be getting the updated events-mixin so this is technically "done" already.

$ npm install ampersand-view
ampersand-view@7.2.0 node_modules/ampersand-view
├── get-object-path@0.0.2
├── matches-selector@1.0.0
├── underscore@1.6.0
├── domify@1.3.2
├── events-mixin@1.2.0 (component-event@0.1.4, delegate-events@1.1.0)
├── ampersand-version@1.0.2 (find-root@0.1.1, through2@0.6.3)
├── ampersand-state@4.4.5 (array-next@0.0.1, key-tree-store@0.1.2, backbone-events-standalone@0.2.2)
├── ampersand-collection-view@1.2.1 (backbone-events-standalone@0.2.6, ampersand-class-extend@1.0.1)
├── component-classes@1.2.4 (component-indexof@0.0.3)
└── ampersand-dom-bindings@3.4.0 (is-array@1.0.1, ampersand-dom@1.4.0, key-tree-store@1.2.0)
@lukekarrys

This comment has been minimized.

Show comment
Hide comment
@lukekarrys

lukekarrys Mar 26, 2015

Contributor

So I think this can be merged, but we dont need to publish.

Contributor

lukekarrys commented Mar 26, 2015

So I think this can be merged, but we dont need to publish.

lukekarrys added a commit that referenced this pull request Mar 26, 2015

Merge pull request #106 from AmpersandJS/events-mixin@1.2.0
events-mixin@1.2.0 to allow function callbacks in events hash

@lukekarrys lukekarrys merged commit 3391761 into master Mar 26, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lukekarrys lukekarrys deleted the events-mixin@1.2.0 branch Mar 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment