Fix issue #87 - Subviews hash should append el #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
whether to replace or append the el has been a long standing issue. although Henrik is in the 'use less DOM' camp, I, as yourself, have also preferred the "new view ~ new sub-DOM approach", unless explicitly replacing. react does this so well with vdom! anyway, +1 from me! |
|
+1 This is the way I would expect things to work if I didn't know what was under the hood. A very sensible update imo. |
cdaringe
added a commit
that referenced
this pull request
Oct 14, 2015
Fix issue #87 - Subviews hash should append el
|
thanks @bryanspears. sorry for the slow approval on that one |
|
changelog updated in README |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous functionality should be preserved if you pass and set
elas part of yourprepareView()function.