Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Contributors Wall to README #723

Merged
merged 4 commits into from Mar 17, 2022
Merged

Adding Contributors Wall to README #723

merged 4 commits into from Mar 17, 2022

Conversation

GovindKrishnan
Copy link
Contributor

Using an open-source web tool called contrib.rocks that sync daily with Contributors Club.

Sort of experimental as I came across this today. But yea, it does no harm to production to say the least. 😅

Using an open-source web tool called contrib.rocks that sync daily with Contributors Club.

Sort of experimental as I came across this today. But yea, it does no harm to production to say the least. 😅
@vercel
Copy link

vercel bot commented Mar 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/amruthpillai/reactive-resume-docs/7wg8DRVr8VYV3vmtLuUQk3BEK3zc
✅ Preview: https://reactive-resume-docs-git-fork-govindkrishnan-main-amruthpillai.vercel.app

[Deployment for 8f5832b canceled]

@AmruthPillai
Copy link
Owner

@GovindKrishnan I love this change, most welcome :) Just one quick addition: could you add the same on the docs as well, found in docs/docs/index.mdx?

@GovindKrishnan
Copy link
Contributor Author

@AmruthPillai Glad you liked it! Have added it to index.mdx as well. 😄 👍

@AmruthPillai
Copy link
Owner

LGTM 🚀

@AmruthPillai AmruthPillai merged commit 7fd96a4 into AmruthPillai:main Mar 17, 2022
@GovindKrishnan
Copy link
Contributor Author

GovindKrishnan commented Mar 17, 2022

@AmruthPillai However, the reason I said this is experimental is that it has a limit of 100 contributors. The tool's website does mention specifying max=numbers as URL parameter but when I tried numbers >100 on large repos, profile pictures duplicated. So remember to check its behaviour once we welcome the 101st contributor. If it randomizes the profile pictures during daily refreshes, all good. Else, it might become static. We'll see anyway. We're 60 already! 😄

UPDATE: It does refresh & reorder those profiles as per the ranking in Contributors Graph based on number of commits. So all good! Top 100 Contributors it is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants