Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Rename Experiment to Block #1147

Closed
4 tasks done
Tracked by #1131
drikusroor opened this issue Jun 24, 2024 · 1 comment · Fixed by #1169
Closed
4 tasks done
Tracked by #1131

Backend: Rename Experiment to Block #1147

drikusroor opened this issue Jun 24, 2024 · 1 comment · Fixed by #1169
Assignees

Comments

@drikusroor
Copy link
Contributor

drikusroor commented Jun 24, 2024

  • move code
  • create migration file
  • add data migration (including backwards migration)
  • create views.py and urls.py
@drikusroor drikusroor self-assigned this Jun 24, 2024
@drikusroor drikusroor changed the title Create "block" app and migrate while keeping the existing blocks (fka experiments). Backend: Create "block" app and migrate while keeping the existing blocks (fka experiments). Jun 24, 2024
@drikusroor drikusroor removed their assignment Jul 1, 2024
@BeritJanssen BeritJanssen added this to the Summer 24 refactor milestone Jul 2, 2024
@BeritJanssen
Copy link
Collaborator

Update: after some discussion, we decided that it might be cleaner and easier to keep the Block model within the Experiment app, as it cannot exist outside an enclosing phase and experiment.

Still, it might be worth while to move the "rules" and the "actions" subdirectories of "experiment" to their own folder. In the Django sense, this is strange, as folders indicate "apps", but these directories really stand outside of the Django logic a bit, as the classes of the rules files and actions don't represent Django models in themselves.

@drikusroor drikusroor changed the title Backend: Create "block" app and migrate while keeping the existing blocks (fka experiments). Backend: Rename Experiment to Block Jul 2, 2024
@drikusroor drikusroor self-assigned this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants