Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Refactor block and block feedback URLs #1184

Merged
merged 9 commits into from
Jul 12, 2024

Conversation

drikusroor
Copy link
Contributor

@drikusroor drikusroor commented Jul 10, 2024

This pull request refactors the URLs for blocks and block feedback in the codebase. It adds the "block" prefix from the URLs and removes the "collection" prefix from experiment URLs. This improves the consistency and readability of the URLs.

API

  • /{blockSlug => /block/{blockSlug}
  • /{blockSlug/feedback => /block/{feedback}
  • /collection/{expCollectionSlug => /{expCollectionSlug}

Resolves #1180

@drikusroor drikusroor self-assigned this Jul 10, 2024
Copy link
Collaborator

@BeritJanssen BeritJanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! But do remove & .gitignore the __snapshots__ directories.

@drikusroor drikusroor force-pushed the refactor/1180-rename-block-urls branch from 46a10c6 to 5636765 Compare July 12, 2024 09:27
@drikusroor drikusroor merged commit efd6595 into develop Jul 12, 2024
15 checks passed
@drikusroor drikusroor deleted the refactor/1180-rename-block-urls branch July 12, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update URLS & Slugs in both Backend & Frontend in one PR (see also below)
2 participants