Auto-format schemas on pull requests #321
Conversation
| @@ -5,6 +5,7 @@ on: | |||
| push: | |||
| paths: | |||
| - datasets/*/dataset.json | |||
| - datasets/*/*/*.json | |||
There was a problem hiding this comment.
This doesn't solve the issue I raised, but maybe that's more of a thing to address in the validator itself.
The issue being that if a table JSON file changes the valdiation should not be run against the changed table JSON file, but against the dataset it is part of.
In addition, if I read the spec correctly, the table JSON files don't need to be in one directly below the directory that contains dataset.json, they could in a directories many levels below that. Does the paths spec allow for datasets/*/**/*.json (mind the double **)?
There was a problem hiding this comment.
Does the paths spec allow for
datasets/*/**/*.json(mind the double**)?
I suppose the workflow should still trigger on push where table-splitted files have been changed. However, in that case the CHANGED_DATASETS should be cleaned up to remove the table-splitted files, but only point to the dataset.json that it's part of. Lets see if I can bash this ...
No description provided.