Protect against related field issue #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for offering this fix. It looks like a good first start. I wonder, would it be possible to have some kind of unit test or example for this? That would make it easier to guarantee this is the right fix. TIA! |
|
I've added a test that fails if the patch is not added. Moreover, I see that the previous test cases passed because the feature Restaurant has a field 'name' and the city also has a field 'name', and so there is collision between the field names. I've thus added a field that does not exist in the Restaurant to ensure the resolution of related. |
|
Last commit needed because your pre-commit hooks are a little too strict on the line lengths... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #24