Fix API performance #839
Merged
Fix API performance #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRF performs a deepcopy() of the serializer._declared_fields before it will handle the request. This is analogous to how Django forms work, and allows updating the fields with request state and 'parent' references. Since the deepcopy() also touched dataset definitions of Amsterdam Schema, it basically took 14sec to copy all those dicts as well. This can be avoided, bringing to performance of DSO-API back to reasonable levels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix massive DSO-API performance issue, due to
deepcopy()DRF performs a
deepcopy()of theserializer._declared_fieldsbefore it will handle the request. This is analogous to how Django forms work, and updating the fields with request state and 'parent' references.Since the
deepcopy()also touched dataset definitions of Amsterdam Schema, it basically took 14sec to copy all those dicts as well. This can be avoided, bringing to performance of DSO-API back to reasonable levels.