Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Chore) Remove connect from departments overview #665

Merged
merged 2 commits into from Mar 9, 2020
Merged

(Chore) Remove connect from departments overview #665

merged 2 commits into from Mar 9, 2020

Conversation

janjaap
Copy link
Contributor

@janjaap janjaap commented Mar 5, 2020

This PR contains changes that remove react-redux's connect function, making the departments overview container a lot cleaner.

Test have been rewritten to cover the changes in the component.

@janjaap janjaap requested a review from jpoppe March 5, 2020 13:36
@jpoppe jpoppe assigned janjaap and unassigned jpoppe Mar 5, 2020
@jpoppe
Copy link
Contributor

jpoppe commented Mar 5, 2020

Thanks!

@janjaap
Copy link
Contributor Author

janjaap commented Mar 6, 2020

PR still requires a review @jpoppe ;)

@janjaap janjaap assigned jpoppe and unassigned janjaap Mar 6, 2020
@janjaap janjaap merged commit b6690fd into develop Mar 9, 2020
@janjaap janjaap deleted the chore-remove-connect-from-departments-overview branch March 9, 2020 07:40
@janjaap janjaap mentioned this pull request Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditudorache aditudorache aditudorache approved these changes

@jpoppe jpoppe Awaiting requested review from jpoppe

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janjaap @jpoppe @aditudorache