Chore remove connect from contacts overview #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janjaap
reviewed
Mar 10, 2020
| @@ -54,14 +52,15 @@ const StyledDataView = styled(DataView)` | |||
| } | |||
| `; | |||
|
|
|||
| export const UsersOverviewContainer = ({ userCan }) => { | |||
| export const UsersOverviewContainer = () => { | |||
There was a problem hiding this comment.
Named export should be removed
janjaap
reviewed
Mar 10, 2020
| @@ -39,7 +37,7 @@ const StyledSearchbar = styled(SearchBar)` | |||
| } | |||
| `; | |||
|
|
|||
| const filtersReducer = (state, action) => { | |||
| const filtersReducer = (_, action) => { | |||
| switch (action.type) { | |||
| case 'username': | |||
| return { username: action.payload }; | |||
There was a problem hiding this comment.
return { ...state, username: action.payload };
janjaap
approved these changes
Mar 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes that remove react-redux's
connectfunction, making theusers overview containera lot cleaner.Test have been rewritten to cover the changes in the component.
(Text has been borrowed from Jan Jaap ;)