Rewritten the Java region class #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main aim of this refactor is to reduce the amount of data that is held in memory. The previous implementation loaded and wrote the whole region file meaning all the data had to be in memory. The new implementation removes the buffer and directly reads and writes to the file on disk removing any need for a buffer of the data. A second class has been implemented extending the first with a buffer to emulate the old behaviour. This is only temporary to keep backwards compatibility and will be depreciated and removed in the future. Ideally where possible the format wrappers should just be a view into the real data and should not implement any form of buffering.
This short circuit could probably cause some issues so I am removing it.
The data needed parsing first
Switched to the new region class that does not cache chunk data. Refactored the region manager class to create region classes only when required rather than parsing all at the start. Removed save and close methods because they no longer do anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main aim of this refactor is to reduce the amount of data that is held in memory.
The previous implementation loaded and wrote the whole region file meaning all the data had to be in memory.
The new implementation removes the buffer and directly reads and writes to the file on disk removing any need for a buffer of the data.
A second class has been implemented extending the first with a buffer to emulate the old behaviour. This is only temporary to keep backwards compatibility and will be depreciated and removed in the future.
Ideally where possible the format wrappers should just be a view into the real data and should not implement any form of buffering.