Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues reloading plugin UI's when having syntax error. #346

Closed
StealthyExpertX opened this issue Jun 26, 2021 · 1 comment · Fixed by #350
Closed

Issues reloading plugin UI's when having syntax error. #346

StealthyExpertX opened this issue Jun 26, 2021 · 1 comment · Fixed by #350
Assignees
Labels
type: bug Something isn't working

Comments

@StealthyExpertX
Copy link
Contributor

I noticed a bug while writing some plugins.

When a plugin has a UI error, you undo your changes to the plugin that caused the issue,
you no longer able to reload the plugin with the reload button after all other plugins' UI's will no longer display correctly.

  1. Create a plugin with a syntax error.
  2. Load Amulet in any version.
  3. Load any random world.
  4. Load the operation that has the error.
  5. Notice no UI in the screenshot is rendering for the working plugin "Set LootTables"
  6. Try reloading the plugin after fixing the issue in the plugin, it will still not fix the UI rendering bug until you reload Amulet.

Expected behavior is that the reload button would reload the plugins and their UIs. One plugin messing up shouldn't affect all other plugins.

image
image

  • OS: Windows 10
  • Version 8.8

My thoughts on this are that syntax errors/issues shouldn't affect the running of the entire program and cause it to not display the UI correctly for other working plugins.

The error that I saw in the console when it was happening.

RuntimeError: wrapped C/C++ object of type SimpleChoice has been deleted

@Podshot Podshot added the type: bug Something isn't working label Jun 26, 2021
@StealthyExpertX
Copy link
Contributor Author

Example: note this was purposely created to replicate the issue, I duplicated some lines in the UI code and the issue is now present.
chest_loot_tablesErrors.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
3 participants