Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise BaseRandom and GaussianGenerator #21

Merged
merged 5 commits into from
Jan 7, 2024
Merged

Optimise BaseRandom and GaussianGenerator #21

merged 5 commits into from
Jan 7, 2024

Conversation

Steveplays28
Copy link
Collaborator

With these changes the optimisations happen right at the source. I also did some refactoring and cleanup on the util classes, renamed some packages, and made all the naming consistent.

If you'd like, AnOpenSauceDev, I'm up to help maintain Faster Random.

Copy link
Owner

@AnOpenSauceDev AnOpenSauceDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why github thought this was a good idea, but it makes zero indication that your pending reviews will only show up after you approve them. So sorry for the apparent delay!

@Steveplays28
Copy link
Collaborator Author

I don't know why github thought this was a good idea, but it makes zero indication that your pending reviews will only show up after you approve them. So sorry for the apparent delay!

@AnOpenSauceDev That's all good!

@AnOpenSauceDev
Copy link
Owner

Adding onto the thread, Faster Random was much messier in caves compared to this PR in terms of generation, but most surface carvers/features were mostly untouched (the position was normal, but the terrain could fluctuate a bit). Creating a seeded random number generator wouldn't change much, as it wouldn't be the same as vanilla anyways.

I'll compare the performance, and merge after that.

@AnOpenSauceDev
Copy link
Owner

I see a 10% increase in performance over Faster Random when making chunks on my system, which I see as reasonable enough to merge. I'll invite you as a collaborator as well.

@AnOpenSauceDev AnOpenSauceDev merged commit ed75b16 into AnOpenSauceDev:master Jan 7, 2024
1 check passed
@Steveplays28 Steveplays28 deleted the refactoring branch January 7, 2024 00:50
@Steveplays28
Copy link
Collaborator Author

Steveplays28 commented Jan 7, 2024

Thanks! I accepted your invites on both GitHub and Modrinth.
If I think of some more stuff to add to Faster Random, I'll let you know.

Do you have a Discord account?

@Steveplays28 Steveplays28 added the enhancement New feature or request label Jan 7, 2024
@AnOpenSauceDev
Copy link
Owner

Do you have a Discord account?

Sorry, I don't really use social platforms publicly.

@Steveplays28
Copy link
Collaborator Author

Steveplays28 commented Jan 7, 2024

All good. I'd like to set up some GitHub Actions stuff for releases in the future, similar to my other mods, but that requires me to enter a Modrinth and a CurseForge API key in the settings.

I see you already released v2.0.0, that's nice. Manually releasing like that also works.

@AnOpenSauceDev
Copy link
Owner

I like to manually update versions, but I'll setup actions for PRs

@Steveplays28
Copy link
Collaborator Author

Alright, cool!
If you want, here's an example, which works with multiple branches for building and publishing using mc-publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants