Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add Windows patch and test from conda-forge #1

Closed
ccordoba12 opened this issue Nov 30, 2018 · 1 comment
Closed

Please add Windows patch and test from conda-forge #1

ccordoba12 opened this issue Nov 30, 2018 · 1 comment

Comments

@ccordoba12
Copy link

ccordoba12 commented Nov 30, 2018 •
edited

Pinging @jjhelmus and @nehaljwani about this one.

This PR conda-forge#2 fixed Pydot on Windows for good. However, its changes haven't been picked up by defaults and hence people is still posting ugly solutions to workaround Pydot's breakage:

https://stackoverflow.com/a/53560595/438386

So could you include those changes and release a new build? Thanks for your help!
jjhelmus pushed a commit that referenced this issue Nov 30, 2018
@nehaljwani
Merge pull request #1 from regro-cf-autotick-bot/1.2.4
cff5e84 
pydot v1.2.4
@jjhelmus
Copy link

jjhelmus commented Nov 30, 2018 •
edited

Done, version 1.3.0 build 1 has the linked changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ccordoba12 @jjhelmus