Skip to content

Commit

Permalink
Don't run inductor tests
Browse files Browse the repository at this point in the history
we're getting an issue with the tests:

ValueError: option names {'--shard-id'} already added

This might be due to out-of-tree tests; after some debugging attempt I'm
removing due to time constraints.

The same tests were showing a "RuntimeError: can't create new thread at interpreter shutdown" on python 3.12

This is detailed here python/cpython#115533

From looking at the pytorch code it looks like there's still some polishing of
support for 3.12 happening so will consider this an upstream error
  • Loading branch information
danpetry committed Apr 18, 2024
1 parent 42be81d commit 4524173
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,6 @@ outputs:
# Note that the `|| true` expression will make the build continue even if the whole script falls over completely
# (for example, in the case of missing imports). There doesn't seem to be a way of making a script exception return
# non-zero but failing tests return zero.
# The inductor tests test the torch.compile backend
- python ./test/run_test.py --inductor --continue-through-error || true # [(gpu_variant or "").startswith("cuda") and (linux and x86_64)]
- python ./test/run_test.py --core --continue-through-error || true
# Run pip check so as to ensure that all pytorch packages are installed
# https://github.com/conda-forge/pytorch-cpu-feedstock/issues/24
Expand Down

0 comments on commit 4524173

Please sign in to comment.