Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testpath 0.6.0 #2

Merged
merged 4 commits into from Jun 22, 2022
Merged

testpath 0.6.0 #2

merged 4 commits into from Jun 22, 2022

Conversation

anaconda-pkg-build
Copy link

Update testpath to 0.6.0

@varlackc
Copy link

varlackc commented Jun 15, 2022

testpath version 0.6.0

    • check the pinnings

flit >=3.2.0,<4
https://github.com/jupyter/testpath/blob/0.6.0/pyproject.toml#L2

python >=3.5
https://github.com/jupyter/testpath/blob/0.6.0/pyproject.toml#L11

    • check the changelogs

    the changes mentioned were bug fixes or new features

    • Removed some code that's unused since dropping Python 2 support.

    • Relax the version constraint for the flit_core build requirement.

    https://github.com/jupyter/testpath/blob/0.6.0/doc/history.rst

    • license is spdx compliant

BSD-3-Clause
https://github.com/jupyter/testpath/blob/0.6.0/LICENSE

https://spdx.org/licenses/BSD-3-Clause.html

    • license family
    • verify the build number
    • verify setuptools
    • verify wheel
    • pip in the test section
    • verify the test section

Results:

Since noarch packages are not built at this time, the package was modified to be an architecture specific package.

Based on the research findings and the results we can conclude
that it is safe to update testpath to version 0.6.0

@varlackc varlackc self-assigned this Jun 15, 2022
@varlackc varlackc requested a review from tobijk June 15, 2022 16:32
@varlackc varlackc changed the title testpath 0.6.0 testpath 0.6.0 Jun 15, 2022
recipe/meta.yaml Outdated
- pip
- flit >=3.2.0,<3.3
- flit >=3.2.0,<4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flit was replaced with flit-core.

https://github.com/AnacondaRecipes/testpath-feedstock/blob/pbs_0.6.0_20220224T100652/recipe/meta.yaml#L20&&L23

As a result, there was an error with the tomli module. The solution for the issue was found in the following issue discussion:

Missing module name tomli
pypa/setuptools_scm#608

by adding a version of setuptools_scm different than 6.1.1 the issue was resolved.

@varlackc varlackc merged commit 1de59db into master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants