Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "mb_substr(): Passing null to parameter #1 ($string) of type string is deprecated" #36

Closed
wants to merge 1 commit into from

Conversation

stayallive
Copy link

As per the title :) Together with #35 this fixes all deprecations raised by the usage of this dependency in Former too 🎉

@kylekatarnls
Copy link

It sounds like this repo is possibly no longer maintained so I forked it.
https://github.com/kylekatarnls/html-object

I switched to GitHub Actions up to PHP 8.3 and merged your compatibility fix.

I would be happy to review/merge other fixes and grant access to the repo to those who might want to contribute on a regular basis.

It can be installed with:

composer remove anahkiasen/html-object
composer require kylekatarnls/html-object

@stayallive
Copy link
Author

@kylekatarnls, this seems like a good solution, with Former though I'm a weary it might introduce some weirdness if another library requires the non-forked dependency. I tried to require both and did not get any errors but wouldn't that cause duplicated classes? I thought I saw some of that in the past but couldn't reproduce so wanted to check in case you had some insights 😄

@kylekatarnls
Copy link

Ah yes, I should add the "replace" key to ensure precedence.

@stayallive stayallive closed this Jan 25, 2024
@stayallive stayallive deleted the patch-1 branch January 25, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants