Add YandexCloud provider #1213
Merged
Add YandexCloud provider #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adferrand
requested changes
Apr 29, 2022
|
Thanks for the review! I think I addressed all your comments, please review the code once more. |
adferrand
approved these changes
Apr 30, 2022
|
Thanks a lot for the timely review and merge! I would be very grateful if https://hub.docker.com/r/adferrand/dnsrobocert will be working with it as well, which I assume requires a re-build of the dnsrobocert image after these changes will be released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for the explicit instructions on the new provider creation. They are easy to follow, and integration tests helped me understand the desired behaviour of the module.