Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Godaddy provider #78

Closed
wants to merge 1 commit into from
Closed

[WIP] Godaddy provider #78

wants to merge 1 commit into from

Conversation

jacobsantos
Copy link

I spent enough time to spec out how the code should be. I am unsure how to test locally. The Dockerfile does not use the local files. I could setup a virtual environment, but I'm not that familiar with Python or at least I haven't yet done that with an existing Python project.

Submitting this for others to test. Also for feedback. Seems to be exactly what I need, so any guidance on getting this in would be appreciated.

@CapsuleCD
Copy link
Contributor

Hi.

I'm an automated pull request bot named CapsuleCD. I handle testing, versioning and package releases for this project.

  • If you're the owner of this repo, you can click the button below to kick off the CapsuleCD build pipeline and create an automated release.'
  • If not, don't worry, someone will be by shortly to check on your pull request.

CapsuleCD


If you're interested in learning more about CapsuleCD, or adding it to your project, you can check it out here

@AnalogJ
Copy link
Owner

AnalogJ commented Dec 2, 2016

Hey @jacobsantos, thanks for the PR.
Yeah, I should add a section to the README specifying how developers can write and test their own providers.

I'm traveling currently, but once I'm back next week I'll take a look at your PR and fix the missing test suite.

👍

@ghub2015 ghub2015 mentioned this pull request Dec 4, 2016
@txr13
Copy link

txr13 commented Jan 10, 2017

This would be super-helpful for me, as well. Definitely willing to help test it!

@AnalogJ
Copy link
Owner

AnalogJ commented Jan 25, 2017

Hey @jacobsantos

Thanks for the PR. I finally got around to putting a contributing.md guide together. It has instructions on how to write a provider, manually test it and run it through the integration suite (with VCRpy recordings).

Can you take a look and update your PR with the VCRpy recordings? Then I can merge your PR immediately :)

@AnalogJ
Copy link
Owner

AnalogJ commented Feb 17, 2017

@jacobsantos ping :)

@AnalogJ
Copy link
Owner

AnalogJ commented Mar 26, 2017

Closing this, there doesn't seem to be any activity.

@AnalogJ AnalogJ closed this Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants