Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use poetry-core for build #787

Merged
merged 2 commits into from Apr 25, 2021
Merged

Use poetry-core for build #787

merged 2 commits into from Apr 25, 2021

Conversation

harens
Copy link
Contributor

@harens harens commented Apr 13, 2021

This should hopefully close #568 by switching from poetry to poetry-core. See python-poetry/poetry#1975 for more details on the issue.

This is done as recommended by the Poetry docs:

If your pyproject.toml file still references poetry directly as a build backend, you should update it to reference poetry_core instead.

I couldn't test this on my machine as a result of pyca/cryptography#3489 occuring with poetry. Hence I marked it as a WIP.

The only thing I'm a bit cautious of is the use of setuptools in the build-system. I don't think it's required for poetry (see python-poetry/poetry#2956 (comment)) but I'm not sure about poetry-core. However, there are other projects with a similar setup.py without needing setuptools in the pyproject.toml, such as rich, so I thought I'd give it a shot and revert it if necessary.

See https://trac.macports.org/ticket/62682 for full discussion.

@harens
Copy link
Contributor Author

harens commented Apr 13, 2021

It seems like tests are failing for unrelated reasons relating specifically to HTTPERROR (maybe #490?).

@commonism
Copy link
Contributor

Glad to see this fails for you as well.
I'm having the similar issues (#786), but I actually touched relevant authorization code, so … seems like something else broke.

@adferrand
Copy link
Collaborator

Just to keep you informed that I follow the discussions, I will invest myself as soon as I have some time.

Copy link
Collaborator

@adferrand adferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I update the PR with master, and tests are passing. LGTM!

@adferrand adferrand changed the title WIP: Use poetry-core for build Use poetry-core for build Apr 25, 2021
@adferrand adferrand merged commit cb24555 into AnalogJ:master Apr 25, 2021
@harens harens deleted the poetry-core branch April 25, 2021 08:11
@harens
Copy link
Contributor Author

harens commented Apr 25, 2021

Thanks @adferrand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fork lexicon without poetry
3 participants