Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre v0.4.16 #328

Merged
merged 14 commits into from
Jul 12, 2022
Merged

pre v0.4.16 #328

merged 14 commits into from
Jul 12, 2022

Conversation

AnalogJ
Copy link
Owner

@AnalogJ AnalogJ commented Jul 9, 2022

  • [feat] frontend javascript changes & tests.
    • adding typescript interfaces for type hinting and testing some code reformatting
    • adding tests for services and components.
    • cleanup of unused dependencies in components.
    • refactor dashboard service so that wrapper is removed before data is passed to component. (no more this.data.data...).
    • refactored components so that variable names are consistent (dashboardService vs smartService).
    • ensure argument and return types are specified everywhere.
    • adding tests for pipes.
    • added ci for frontend code.
  • [feat] added mechanism to update InfluxDB tasks if they get out of date (due to updates in the code).
  • [fix] Historical temperature data is inconsistent and is not downsampled correct
  • [docs] added and fixed links to supported NAS's
  • [feat] upgrading to go 1.18 for generics (and lodash-like library)
  • [fix] devices with an empty wwn should be filtered out (not uploaded during device registration, skipped when attempting to upload metrics).
  • [docs] added USB instructions to trouble shooting guide.
  • [docs] added instructions for how to create a Scope restricted InfluxDB API token for use with Scrutiny.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2022

Codecov Report

Merging #328 (7841063) into master (c2488af) will increase coverage by 6.35%.
The diff coverage is 49.13%.

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   26.34%   32.69%   +6.35%     
==========================================
  Files          25       51      +26     
  Lines        2050     2753     +703     
  Branches        0       61      +61     
==========================================
+ Hits          540      900     +360     
- Misses       1489     1821     +332     
- Partials       21       32      +11     
Flag Coverage Δ
unittests 32.69% <49.13%> (+6.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
collector/pkg/collector/metrics.go 0.00% <0.00%> (ø)
webapp/backend/pkg/database/scrutiny_repository.go 13.52% <0.00%> (+13.52%) ⬆️
...end/pkg/database/scrutiny_repository_migrations.go 0.00% <0.00%> (ø)
...p/frontend/src/app/data/mock/device/details/sda.ts 100.00% <ø> (ø)
webapp/frontend/src/app/data/mock/summary/data.ts 100.00% <ø> (ø)
...dialog/dashboard-device-delete-dialog.component.ts 100.00% <ø> (ø)
webapp/frontend/src/app/layout/layout.component.ts 2.50% <0.00%> (ø)
webapp/frontend/src/app/shared/device-sort.pipe.ts 3.12% <0.00%> (ø)
...ebapp/frontend/src/app/shared/device-title.pipe.ts 89.28% <0.00%> (ø)
webapp/frontend/src/app/shared/temperature.pipe.ts 86.66% <ø> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff17128...7841063. Read the comment docs.

@AnalogJ AnalogJ changed the title adding tests to frontend. pre v0.4.16 Jul 9, 2022
some code reformatting
adding tests for services and components.
cleanup of unused dependencies in components.
refactor dashboard service so that wrapper is removed before data is passed to component. (no more this.data.data...).
refactored components so that variable names are consistent (dashboardService vs smartService).
ensure argument and return types are specified everywhere.
adding tests for pipes.

adding ng test to ci steps.

change dir before running npm install.

trying to install nodejs in continer.

test frontend separately.

upload coverage for frontend and backend.

upload coverage for frontend and backend.

testing coverage file locations.

retry file upload.
devices with an empty wwn should be filtered out (not uploaded during device registration, skipped when attempting to upload metrics).
added a migration to delete existing device entries with an empty `wwn`

fixes #314
fixes #266

added solaris to supported os list.
This reverts commit 64e1c93.
https://gitlab.com/cznic/sqlite does not support Solaris.
> build constraints exclude all Go files in /home/runner/work/scrutiny/scrutiny/vendor/modernc.org/libc/errno

related #120
@AnalogJ AnalogJ merged commit 550fb54 into master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants