Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade shoutrrr to 0.6.1 #355

Closed
wants to merge 5 commits into from
Closed

Upgrade shoutrrr to 0.6.1 #355

wants to merge 5 commits into from

Conversation

davralin
Copy link

@davralin davralin commented Aug 4, 2022

Could you upgrade shoutrrr to a newer version?

This brings in support for more notification libraries, for instance matrix - which I'm looking for.

@AnalogJ AnalogJ changed the base branch from master to beta August 4, 2022 14:17
@AnalogJ
Copy link
Owner

AnalogJ commented Aug 4, 2022

Thanks for the PR! 🎉

looks like you forgot to update the go.sum file.
can you run go mod tidy and commit that file?

@davralin
Copy link
Author

davralin commented Aug 4, 2022

Thanks for the PR! tada

looks like you forgot to update the go.sum file. can you run go mod tidy and commit that file?

Forgot? No, I just have no idea what I'm doing! :)
I hoped it was as easy as bumping the version number for it to happen.

I'll see what I can make of it.

@AnalogJ
Copy link
Owner

AnalogJ commented Aug 4, 2022

oh in that case, let me see if I can edit your PR branch. I think github has a feature like that.

@davralin
Copy link
Author

davralin commented Aug 8, 2022

I successfully ran go mod tidy in a container, that did bring in several other things - I'm guessing these are updated modules from upstream projects.

You probably also want those perhaps, so I didn't remove them.

Let me know if you want me to just bring in the stuff I need for shoutrrr to be upgraded.

@AnalogJ
Copy link
Owner

AnalogJ commented Aug 10, 2022

this is great, thanks! I'll make sure it's included in the next release (v0.5.1) 🥳

@davralin
Copy link
Author

Do you have any plans to update to 0.5.1 any time soon?

An updated apprise-library is key for me to use this, and I really need something to monitor my drives.

AnalogJ added a commit that referenced this pull request Jan 12, 2023
@AnalogJ AnalogJ mentioned this pull request Jan 12, 2023
@AnalogJ AnalogJ closed this in #425 Jan 12, 2023
@AnalogJ
Copy link
Owner

AnalogJ commented Jan 12, 2023

hey @davralin
Sorry for the delay getting this change implemented, I've been busy with another project.
I just released v0.6.0 which includes this change. Can you pull it down and test it?

@davralin davralin deleted the feat/upgrade-shoutrrr branch February 5, 2023 14:37
@davralin
Copy link
Author

Took me quite some time, but all good! I have successfull notifications on matrix now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants