Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing bug. Null value for temperatures should be ignored. #394

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

AnalogJ
Copy link
Owner

@AnalogJ AnalogJ commented Nov 6, 2022

fixes #393

@codecov-commenter
Copy link

Codecov Report

Merging #394 (2677796) into master (a01b8fe) will decrease coverage by 0.14%.
The diff coverage is 28.10%.

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   32.69%   32.54%   -0.15%     
==========================================
  Files          51       54       +3     
  Lines        2753     3045     +292     
  Branches       61       66       +5     
==========================================
+ Hits          900      991      +91     
- Misses       1821     2018     +197     
- Partials       32       36       +4     
Flag Coverage Δ
unittests 32.54% <28.10%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
collector/pkg/collector/base.go 0.00% <ø> (ø)
webapp/backend/pkg/config/config.go 0.00% <0.00%> (ø)
webapp/backend/pkg/database/scrutiny_repository.go 12.60% <0.00%> (-0.92%) ⬇️
...end/pkg/database/scrutiny_repository_migrations.go 0.00% <0.00%> (ø)
...ckend/pkg/database/scrutiny_repository_settings.go 0.00% <0.00%> (ø)
...nd/pkg/database/scrutiny_repository_temperature.go 45.98% <0.00%> (-0.69%) ⬇️
webapp/frontend/src/app/layout/layout.component.ts 2.50% <20.00%> (ø)
...end/src/app/core/config/scrutiny-config.service.ts 42.85% <42.85%> (ø)
...bapp/frontend/src/app/shared/device-status.pipe.ts 64.70% <62.50%> (+54.70%) ⬆️
webapp/frontend/src/app/shared/file-size.pipe.ts 78.57% <76.92%> (-6.05%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AnalogJ AnalogJ merged commit 075eb94 into master Nov 15, 2022
@AnalogJ AnalogJ deleted the skip_null_temp branch November 15, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Invalid temp values in database
3 participants