Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

patch package.json to support ESM workflows #1

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

thescientist13
Copy link

@thescientist13 thescientist13 commented Dec 11, 2021

Doing my best guess here to get this package working with ESM

  1. Main issue was the entry point, which is an empty file, so needed to override. The current file I have now seems to work without the need of the below point
  2. As part of testing, saw cases where dist/ code referenced a bare module of @stencil/core which is only treated as a devDependency by web-social-share and led to missing dependencies in my local project. So if that is actual intentional or not, if generated Stencil files do reference @stencil/* they will need to captured as peerDependencies
  3. In my project, it was necessary to use a Rollup plugin to handle building dynamic imports that use variables in them

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant