Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade greenwood v0.28.0 and GitHub Actions for node 18 #85

Merged
merged 16 commits into from
Jun 17, 2023

Conversation

thescientist13
Copy link
Contributor

@thescientist13 thescientist13 commented Dec 17, 2022

Related Issue

N / A

Summary of Changes

  1. Upgrade latest Greenwood v0.28.0
  2. Update project for Node 18
  3. Updated WTR config per latest plugin refactoring

TODO

  1. Need to upgrade / patch font-awesome plugin for Greenwood v0.28.0 (just vendoring for right now) - upgrade latest Greenwood v0.28.0 greenwood-plugin-font-awesome#6
  2. API routes getting confused with API calls yarn serve (though API calls work just fine) - API calls are getting treated as API routes with the serve command ProjectEvergreen/greenwood#1059
    Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/owenbuckley/Workspace/analogstudios.net/repo/www.analogstudios.net/src/api/v2/events.js' imported from /Users/owenbuckley/Workspace/analogstudios.net/repo/www.analogstudios.net/node_modules/@greenwood/cli/src/plugins/resource/plugin-api-routes.js
  3. SPA fallback handing not working - SPA fallback handling not working (v0.28.0-alpha.1) ProjectEvergreen/greenwood#1064
    Screen Shot 2023-02-10 at 9 52 12 AM
  4. Dev Proxy routing returning HTML for local dev server and no data is showing - break after first found resource match for dev server serve lifecycle ProjectEvergreen/greenwood#1084
    Screen Shot 2023-03-25 at 11 00 55 AM

@netlify
Copy link

netlify bot commented Dec 17, 2022

Deploy Preview for practical-fermat-fa2c48 failed.

Name Link
🔨 Latest commit e69c329
🔍 Latest deploy log https://app.netlify.com/sites/practical-fermat-fa2c48/deploys/639e0f4cb480290008a23de8

@thescientist13 thescientist13 marked this pull request as ready for review April 2, 2023 00:05
@thescientist13 thescientist13 changed the title upgrade greenwood and GitHub Actions for node 18 upgrade greenwood v0.28.0 and GitHub Actions for node 18 May 6, 2023
@thescientist13 thescientist13 merged commit 0dfd3c8 into main Jun 17, 2023
6 checks passed
@thescientist13 thescientist13 deleted the chore/upgrade-greenwood-v0.28.0 branch June 17, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

None yet

1 participant