Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

apply lighthouse recommendations #41

Merged
merged 4 commits into from
Apr 29, 2023
Merged

apply lighthouse recommendations #41

merged 4 commits into from
Apr 29, 2023

Conversation

thescientist13
Copy link
Contributor

@thescientist13 thescientist13 commented Apr 28, 2023 •
edited
Loading

Related Issue

resolves #16

Screen Shot 2023-04-28 at 8 26 35 PM

(The SEO score is just due to Netlify preview deploys blocking indexing)

Summary of Changes

  1. Image sizing Lighthouse feedback (secret, width + height)
  2. Address low text color contrast (adjusted hex color to #db0000)
  3. Apply correct resolution / sizing to mobile RI map image
  4. Inline CSS

TODO

  1. Low contrast text
  2. Image Resolution
  3. Track an issue to align accessible text color with other images assets and align w/ designs and styleguide) - align images with accessibility complaint font color #43

@thescientist13 thescientist13 added the enhancement New feature or request label Apr 28, 2023
@thescientist13 thescientist13 changed the title image sizing lighthouse feedback enhancements apply lighthouse feedback recommendations Apr 29, 2023
@thescientist13 thescientist13 mentioned this pull request Apr 29, 2023
Open
@thescientist13 thescientist13 marked this pull request as ready for review April 29, 2023 00:27
@thescientist13 thescientist13 changed the title apply lighthouse feedback recommendations apply lighthouse recommendations Apr 29, 2023
@thescientist13 thescientist13 merged commit 548b06b into main Apr 29, 2023
5 checks passed
@thescientist13 thescientist13 deleted the enhancement/issue-16-lighthouse-audit branch April 29, 2023 00:29
@thescientist13 thescientist13 linked an issue Apr 29, 2023 that may be closed by this pull request
Lighthouse audit #16
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lighthouse audit
1 participant
@thescientist13