Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

feature/issue 57 FAQ page #71

Merged
merged 11 commits into from
May 21, 2023
Merged

feature/issue 57 FAQ page #71

merged 11 commits into from
May 21, 2023

Conversation

thescientist13
Copy link
Contributor

@thescientist13 thescientist13 commented May 8, 2023

Related Issue

resolves #57

Summary of Changes

  1. Created FAQ ToC and Content
  2. Integrated Google Maps and IYRS aerial photo

TODOs

  1. Styling at all breakpoints
    • mobile
    • md
    • lg / xl
  2. IYRS image
  3. ToC
  4. FAQ Content
  5. FAQ Card test cases Storybook
  6. Should ToC nav items match headings?
  7. Lighthouse Audit
  8. Browser testing

Upstreams?

  • WCC double attributes / content ("directive" to opt-our of unwrapping at component level) - make <slot> work for non shadow DOM too?

@thescientist13 thescientist13 added feature content Copy text / content labels May 8, 2023
@thescientist13 thescientist13 changed the title feature/faq page feature/issue 57 FAQ page May 14, 2023
<bf-faq-card
label="emergency"
heading="What if there is an emergency?"
content="Blissfest will abide by all local building codes and inspection guidelines. In addition a police detail will be on site to assist with an emergency."

This comment was marked as resolved.

@thescientist13 thescientist13 added the question Further information is requested label May 14, 2023
Copy link
Contributor Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ding on best practices was due to Google Maps, though we are loading it lazily so 🤷‍♂️
Screen Shot 2023-05-14 at 7 28 14 PM

@thescientist13 thescientist13 marked this pull request as ready for review May 14, 2023 23:29
@thescientist13 thescientist13 merged commit 2d435cd into main May 21, 2023
5 checks passed
@thescientist13 thescientist13 deleted the feature/issue-57-faq-page branch May 21, 2023 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
content Copy text / content feature question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAQ Page
1 participant