This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
feature/issue 70 assemble first wave of pages and content #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for cheerful-melomakarona-41a6ad failed.
|
thescientist13
force-pushed
the
feature/issue-70-assemble-first-wave-pages-and-content
branch
from
a14ccd1
to
7a0ba39
Compare
thescientist13
force-pushed
the
feature/issue-70-assemble-first-wave-pages-and-content
branch
from
7a0ba39
to
188c320
Compare
thescientist13
changed the title
thescientist13
commented
May 24, 2023
There was a problem hiding this comment.
Found the root cause of the high CLS score. Grabbed a recording and can see after the font loads the navigation goes from two lines to one line, which causes everything to jump up a bit.
https://github.com/AnalogStudiosRI/www.blissfestri.com/assets/895923/261a399b-fcd0-436c-99a5-311d0f33f1ac
Seems like just a tweak to the font styles helped here, and maybe could be revisited as more items are added back to the list?
thescientist13
commented
May 26, 2023
4 tasks
thescientist13
deleted the
feature/issue-70-assemble-first-wave-pages-and-content
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #53 and #70
Summary of Changes
TODO
stsge spelling mistakeput Bill first in the lineupon mobile, bump tickets text underneath the stub imageLineup container seems cramped on mobile (text overflowing)inline<form>on medium breakpointsstar separator aspect ratioscreen form edge image as webpheader image resizePerf is only 86, maybe due to CLS and having too much hidden stuff on the page?- feature/issue 70 assemble first wave of pages and content #81 (review)