Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 16 upcoming events #37

Merged
merged 8 commits into from
Oct 16, 2022

Conversation

thescientist13
Copy link
Contributor

@thescientist13 thescientist13 commented Oct 9, 2022

Related Issue

resolves #16 (design adapted slightly to be a little more compact)

Screen Shot 2022-10-11 at 9 14 24 AM

Summary of Changes

  1. Styling and templating for Upcoming Events component (still needs a little more tweaking)
  2. Created Storybook with a variety of scenarios

TODO

  1. A a ' in JSON will break JSON.stringify ⚠️
    • left a note, hopefully not an issue for integration, since I plan on using setAttribute 🤞
  2. Add test cases
  3. Add overflow containment to allow for fixed height, maybe as a prop? (help wanted)
  4. Have event text all left justify each date block so they are flush with each other horizontally (help wanted)
  5. Create event for season premier (non blocking)

Still need to figure out the data story for home page integration

  • hmm, I think we'll SSR compatible fetch since we're using prerender, so we might need to convert index.html -> index.js or find some sort of isomorphic fetch implementation?
  • Fetch data from page and pass down to component
  • Have Contentful trigger Netlify rebuilds based on content changes

I think general rule of thumb will be:

  • static content - data in component
  • dynamic content - pass data from parent / page via SSR

@thescientist13 thescientist13 added help wanted Extra attention is needed feature New feature or request labels Oct 9, 2022
@thescientist13 thescientist13 self-assigned this Oct 9, 2022
@thescientist13 thescientist13 added the question Further information is requested label Oct 9, 2022
@thescientist13 thescientist13 marked this pull request as ready for review October 16, 2022 16:48
@thescientist13 thescientist13 added documentation Improvements or additions to documentation and removed question Further information is requested labels Oct 16, 2022
@thescientist13 thescientist13 merged commit a6945a1 into v1 Oct 16, 2022
@thescientist13 thescientist13 deleted the feature/issue-16-upcoming-events branch October 16, 2022 18:32
thescientist13 added a commit that referenced this pull request Oct 25, 2022
* init commit of WIP upcoming events component

* handle multiple months, multiple events, and out order sorting

* support no upcoming events

* keep events in the current month in the list

* spruce up event alignment and justification

* add unit tests

* updated styling

* leave note about JSON serialization issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upcoming Episode / Schedule
1 participant