Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run WebGL tests in CI #4281

Closed
pjcozzi opened this issue Sep 4, 2016 · 0 comments
Closed

Run WebGL tests in CI #4281

pjcozzi opened this issue Sep 4, 2016 · 0 comments

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 4, 2016

As discussed with @mramato offline:

  • Replace all read pixels expectations with a function that can have a no-op expectation when the tests are ran with a "no WebGL" flag, e.g.,
expect(scene.renderForSpecs()).toEqual([0, 0, 0, 255]);

becomes

scene.expectRenderForSpecs([0, 0, 0, 255]);
  • Replace the object returned by getContext with a mock object with GL functions that are no-ops, function() {}, except for getExtension, which should return mocked objects for the extensions we care about.
    • Likewise, all gl.get* functions should be mocked to return reasonable values.
  • Run the tests and fix things I forgot.

This should only take a few hours and will be more reliable than mesa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant