Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setView in 2D and CV #2996

Merged
merged 4 commits into from
Sep 14, 2015
Merged

Fix setView in 2D and CV #2996

merged 4 commits into from
Sep 14, 2015

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Sep 2, 2015

  • Seperate set view for the three scene modes.
  • Clone input.
  • Add more tests to ensure correctness.

For #2943.

@mramato
Copy link
Contributor

mramato commented Sep 3, 2015

Running the sample code in the linked issue seems to cause multiple crashes. Zoom in a little and hit orient north

@hpinkos
Copy link
Contributor

hpinkos commented Sep 5, 2015

@mramato it doesn't crash for me.

@mramato
Copy link
Contributor

mramato commented Sep 11, 2015

@hpinkos sorry, it only happens if you remove the clone.

This should definitely crash.

var viewer = new Cesium.Viewer('cesiumContainer');

Sandcastle.addToolbarButton('Orient North', function(){
    viewer.scene.camera.setView({
        position: viewer.scene.camera.positionWC,
        roll: 0,
        pitch: -Cesium.Math.PI_OVER_TWO,
        heading: 0
    });
});

@bagnell
Copy link
Contributor Author

bagnell commented Sep 14, 2015

@mramato The crash is fixed.

@mramato
Copy link
Contributor

mramato commented Sep 14, 2015

I updated CHANGES and everything looks good. Thanks.

mramato added a commit that referenced this pull request Sep 14, 2015
@mramato mramato merged commit f846b3a into master Sep 14, 2015
@mramato mramato deleted the setView branch September 14, 2015 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants