Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*3DTileContentProvider* renamed to *3DTileContent* #3518

Merged
merged 3 commits into from
Feb 4, 2016
Merged

*3DTileContentProvider* renamed to *3DTileContent* #3518

merged 3 commits into from
Feb 4, 2016

Conversation

TomPed
Copy link
Contributor

@TomPed TomPed commented Feb 4, 2016

For #3241

Reamed *3DTileContentProvider* to *3DTileContent*.

As for the change in CHANGES.md does it make sense to have this change or no? (I think that it does).

@lilleyse
Copy link
Contributor

lilleyse commented Feb 4, 2016

As for the change in CHANGES.md does it make sense to have this change or no? (I think that it does).

Yeah that change makes sense.

@lilleyse
Copy link
Contributor

lilleyse commented Feb 4, 2016

Make sure to also change the names in

  • Cesium3DTileBatchTableResources
  • Cesium3DTileBatchTableResourcesSpec
  • Composite3DTileContent

@TomPed
Copy link
Contributor Author

TomPed commented Feb 4, 2016

I did a search for 3DTileContentProvider in these files and I don't see anything. Should I just be looking for the word Provider and remove that?

@lilleyse
Copy link
Contributor

lilleyse commented Feb 4, 2016

I just did a search for ContentProvider.

@TomPed
Copy link
Contributor Author

TomPed commented Feb 4, 2016

Oh, okay, I thought we where only changing 3DTileContentProviders. I'll make these changes.

@TomPed
Copy link
Contributor Author

TomPed commented Feb 4, 2016

Updated.

@TomPed
Copy link
Contributor Author

TomPed commented Feb 4, 2016

Okay I'll change that, I was not sure so I took a look at this and got more confused, 😄. I'll make the change.

@TomPed
Copy link
Contributor Author

TomPed commented Feb 4, 2016

Updated.

@lilleyse
Copy link
Contributor

lilleyse commented Feb 4, 2016

Yeah I see your point about contents being ambiguous here, but it's okay for now. Merged.

lilleyse added a commit that referenced this pull request Feb 4, 2016
…3DTileContent

*3DTileContentProvider* renamed to *3DTileContent*
@lilleyse lilleyse merged commit 9bd537b into CesiumGS:3d-tiles Feb 4, 2016
@lilleyse lilleyse deleted the rename-3DTileContentProvider-to-3DTileContent branch February 4, 2016 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants