3D Tiles cache management #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * The corresponding node in the cache replacement list. | ||
| * | ||
| * @type {DoublyLinkedList} |
|
That's all my comments. I like the approach here. Have you tried this on city datasets? |
Yes, Seattle and Washington DC. |
|
Updates based on review in de9b45a. Let me know your thoughts on #3808 (comment) |
|
Updated in 515f3bd. |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3D Tiles now maintain a LRU cache of tiles to ensure only a maximum number of tiles, specified by the user, are loaded (unless more are needed to meet the SSE for the current view).
There's lots of interesting future work in the Cache Management section of the roadmap, #3241.