Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of weird entity show problems #6835

Merged
merged 2 commits into from
Jul 25, 2018

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jul 24, 2018

Fixes #2909
Fixes #4714
Fixes #6830

We were copying the stored attribute value from the previous geometry to the new geometry instead of updating the stored attributes values to match the new geometry ones. 🤦‍♀️

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@mramato
Copy link
Contributor

mramato commented Jul 24, 2018

The real story here is that I somehow was unaware of the facepalm emojis. So thanks for the bugfix and emoji lesson.

I'll take a look at this later today.

@mramato
Copy link
Contributor

mramato commented Jul 25, 2018

I can't believe this code survived this long unnoticed (one of those bugs is over 3 years old!). Thanks for catching this @hpinkos I'm sure there is a lot of oddness people have ran into that is now fixed. Thanks @lilleyse for such an easy to reproduce test case.

@mramato mramato merged commit 7a7373c into master Jul 25, 2018
@mramato mramato deleted the fix-entity-geometry-attributes branch July 25, 2018 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants