Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspecting accessor data sometimes shows incorrect values #160

Closed
Mknsri opened this issue Apr 27, 2019 · 5 comments · Fixed by #161
Closed

Inspecting accessor data sometimes shows incorrect values #160

Mknsri opened this issue Apr 27, 2019 · 5 comments · Fixed by #161

Comments

@Mknsri
Copy link

Mknsri commented Apr 27, 2019

When inspecting the accessors 5 or 7 on the attached model the inspector shows the data incorrectly or just with the wrong value.

Specifically accessor 5 repeats the same 2 matrices multiple times:
image

And accessor 7 shows the first component of the vector as -0.00... when it in reality is -9.3710...
image

VS Code version:
Version: 1.33.1 (user setup)
Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8

Plugin version:
2.2.4

sneik.zip

@bghgary
Copy link
Contributor

bghgary commented Apr 29, 2019

Thanks for the report. I can confirm something is wrong. In the mean time, if you use Go to Definition (F12), it seems to show the correct values.

@bghgary
Copy link
Contributor

bghgary commented Apr 29, 2019

I have a fix for the matrix values. I accidentally broke it in the last PR.

The accessor 7 issue is not an issue. The values are correct. The double values show as:
image
The values are being formatted to 5 decimals places. The first value results in 0.00000.

@emackey
Copy link
Member

emackey commented Apr 30, 2019

@Mknsri I'll get this fix published sometime in the next few days.

Did the accessor 7 explanation make sense to you? The e-9 on the end of that number makes it too small to be seen in the first five digits. It's roughly -0.000000009371...

Thanks for the report!

@Mknsri
Copy link
Author

Mknsri commented Apr 30, 2019 via email

@emackey
Copy link
Member

emackey commented May 5, 2019

Version 2.2.5 of gltf-vscode was just published. Thanks for the fix @bghgary. This version also includes an upgrade from Babylon 4.0.0-alpha.26 to 4.0.3 stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants