Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "when" commands are available in certain contexts #228

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

emackey
Copy link
Member

@emackey emackey commented Nov 2, 2021

This refines when import (GLB-to-gltf) and export (gltf-to-GLB) commands appear in certain menus, and generally tries to make a cleaner distinction between registerCommand vs. registerTextEditorCommand.

  • Import (convert .glb to .gltf) and export (convert .gltf to .glb) are now available from VSCode's file explorer window context menu, and all operate on the chosen file (not the active editor, as the "export" command previously did).
  • glTF-related commands shouldn't appear in context menus of files without .gltf/.glb extensions.
  • Preview/Inspect/DataURI commands are no longer available in the title-bar context menu, because they only operate on the active editor. They are available from the editor text context menu, the command pallette, and still assigned the same keyboard shortcuts as before.

Superscedes #225.

@emackey emackey merged commit 27e975e into master Nov 3, 2021
@emackey emackey deleted the context-when branch November 3, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant