Add "Quick Fix" for BUFFER_VIEW_TARGET_MISSING #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fairly confident in this now, so I'm merging it. If anyone finds problems, file a new issue please. |
|
This is now published as glTF Tools v2.3.14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely certain of the utility of this vs. the novelty, but I've added simple logic for a "Quick Fix" of
BUFFER_VIEW_TARGET_MISSING.@lexaknyazev I hope the logic here isn't too simplistic for what it's doing. It expects
BUFFER_VIEW_TARGET_MISSINGto have been issued on either a primitive attribute or a primitive's indices, and then expects the value at that JSON pointer to be the ID of a valid accessor with abufferViewID included, and expects that bufferView to be in need of atargetof type determined by whether the original key wasindicesor not, and inserts the value there.This now offers an option to fix all bufferViews in the file.
There is an additional QuickFix for ACCESSOR_JOINTS_USED_ZERO_WEIGHT.
The README has been updated to explain the Quick Fixes.