Updates to allow Draco mesh decoding to be viewable (in ThreeJS and BabylonJS) and navigable (#89). #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! I'll try to get this reviewed soon. |
emackey
reviewed
Mar 20, 2018
| @@ -124,6 +125,7 @@ export class GltfPreviewDocumentContentProvider implements TextDocumentContentPr | |||
|
|
|||
| // Note that with the file: protocol, we must manually specify the UTF-8 charset. | |||
| const content = this._mainHtml.replace('{assets}', | |||
| `<script type="text/x-draco-decoder" src="${this.getFilePath('engines/Draco/draco_decoder.js')}"></script>` + | |||
There was a problem hiding this comment.
I'd like to replace this with a new string in the existing map. I'll push a change here.
emackey
approved these changes
Mar 20, 2018
|
Just pushed a Cesium update to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.