Add animation controls to Babylon preview. #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emackey Do you mind if I make changes to this? It will be a lot easier to explain how to do it by actually writing the code. |
|
Please, by all means, make a branch off this one. Just be aware that AGI requires an emailed CLA to accept direct code contributions. |
|
I created a playground: http://playground.babylonjs.com/#3D23K4#2 that show how I would expect things to work. Start/Stop should work, pausing should not be necessary. |
|
That alien head creeps me out. But the code looks cleaner now. |
bghgary
reviewed
Mar 28, 2018
pages/babylonView.js
Outdated
| @@ -50,6 +64,10 @@ window.BabylonView = function() { | |||
| scene = new BABYLON.Scene(engine); | |||
| scene.useRightHandedSystem = true; // This is needed for correct glTF normal maps. | |||
|
|
|||
| BABYLON.SceneLoader.OnPluginActivatedObservable.add(function (plugin) { | |||
| plugin.animationStartMode = BABYLON.GLTFLoaderAnimationStartMode.NONE; | |||
| }); | |||
There was a problem hiding this comment.
Might consider doing this also:
BABYLON.SceneLoader.OnPluginActivatedObservable.add(function (plugin) {
plugin.animationStartMode = BABYLON.GLTFLoaderAnimationStartMode.NONE;
}, undefined, undefined, undefined, true);
This will make the observable unregister itself after it fires.
bghgary
approved these changes
Mar 28, 2018
|
Thanks @bghgary! |
|
Version 2.1.9 is published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87.
@bghgary This is the strategy used here:
At startup, I iterate the list of
scene.animationGroupsto collect the names, I start any that aren't started (because I don't have a reference to the glTF loader to set the "all" flag), and I immediatelypause()andreset()all the started animations (so they are "stopped" from a user point of view, but Babylon just thinks they're paused).When the user toggles the UI, I call
animationGroup.pause(); animationGroup.reset();oranimationGroup.restart();to get the animation paused or restarted.In my experiments, I was never able to restart an animation after calling
stopon it. So, I get them all into a started-but-paused state and just un-pause them or re-pause and reset them when the UI changes.