Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use msgspec as default serializer #40

Merged
merged 5 commits into from
Jun 10, 2023
Merged

Conversation

Ananto30
Copy link
Owner

No description provided.

@Ananto30 Ananto30 changed the title feat: User msgspec as default serializer feat: Use msgspec as default serializer May 30, 2023
@Ananto30 Ananto30 force-pushed the feat/msgspec-default-serializer branch from 77010dc to 414a290 Compare May 30, 2023 20:46
@Ananto30 Ananto30 force-pushed the feat/msgspec-default-serializer branch from 414a290 to 4ed885a Compare May 30, 2023 20:51
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 96.55% and project coverage change: +0.36 🎉

Comparison is base (3fab0f4) 79.08% compared to head (7910306) 79.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   79.08%   79.44%   +0.36%     
==========================================
  Files          25       25              
  Lines         631      647      +16     
==========================================
+ Hits          499      514      +15     
- Misses        132      133       +1     
Impacted Files Coverage Δ
zero/codegen/codegen.py 26.92% <ø> (ø)
zero/encoder/protocols.py 66.66% <75.00%> (-4.77%) ⬇️
zero/utils/type_util.py 91.17% <96.00%> (+1.17%) ⬆️
zero/__init__.py 100.00% <100.00%> (ø)
zero/client_server/client.py 100.00% <100.00%> (ø)
zero/client_server/server.py 100.00% <100.00%> (ø)
zero/config.py 100.00% <100.00%> (ø)
zero/encoder/factory.py 83.33% <100.00%> (ø)
zero/encoder/msgspc.py 100.00% <100.00%> (ø)
zero/pubsub/publisher.py 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ananto30 Ananto30 force-pushed the feat/msgspec-default-serializer branch from 580141d to 4c17159 Compare June 7, 2023 09:49
@Ananto30 Ananto30 force-pushed the feat/msgspec-default-serializer branch from 4c17159 to 5a78381 Compare June 7, 2023 19:32
@Ananto30 Ananto30 force-pushed the feat/msgspec-default-serializer branch from 2cbb761 to 7910306 Compare June 10, 2023 07:03
@Ananto30 Ananto30 marked this pull request as ready for review June 10, 2023 07:08
@Ananto30 Ananto30 linked an issue Jun 10, 2023 that may be closed by this pull request
@Ananto30 Ananto30 changed the title feat: Use msgspec as default serializer Use msgspec as default serializer Jun 10, 2023
@Ananto30 Ananto30 merged commit dd3aafb into main Jun 10, 2023
17 checks passed
@Ananto30 Ananto30 deleted the feat/msgspec-default-serializer branch June 10, 2023 07:11
@jcrist
Copy link

jcrist commented Jun 11, 2023

Hi, msgspec author here. This is a cool project, and is exactly the kind of use case I originally wrote msgspec for (msgspec was originally written to replace the comms framework used in dask, which has a similar architecture). Glad to see it being used for this use case by someone :). Please let me know if you run into any issues or rough edges.

Would you mind if I added zero to the used by section of our docs?

@Ananto30
Copy link
Owner Author

@jcrist amazing to hear from you and thank you! Dask is amazing, people asked me about Zero vs Dask, and I don't have a quite strong point except Zero is more focused on client-server comm. And also Msgspec is promising! I hope it will be more accepted in the community.

Please feel free to add zero in the msgspec's used by.

@jcrist
Copy link

jcrist commented Jun 11, 2023

Please feel free to add zero in the msgspec's used by.

Thanks! Done here: jcrist/msgspec#437.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easy way to use ormsgpack as encoder
2 participants