Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some downloads corrupted #2

Closed
dualmoon opened this issue Sep 22, 2012 · 7 comments
Closed

Some downloads corrupted #2

dualmoon opened this issue Sep 22, 2012 · 7 comments

Comments

@dualmoon
Copy link

Downloads from fileshare sites like zippyshare, or downloads from any other site that uses download scripts instead of direct download links, tend to be corrupted. Sometimes they are error HTML files, sometimes just text files.

@Anasthase
Copy link
Owner

Hi,

I don't know what download you're talking about... I only put downloads here on GitHub and on the Android Market (now Google Play Store). If peoples put downloads on others locations, i'm not responsible for it. Can you give me some example of these downloads ?

@dualmoon
Copy link
Author

I'm sorry I wasn't more clear. I mean when you download files from within tint browser.

Sent from my android device.

-----Original Message-----
From: Anasthase notifications@github.com
To: Anasthase/TintBrowser TintBrowser@noreply.github.com
Cc: Ashley Davis dual@gmx.com
Sent: Sat, 22 Sep 2012 6:15 AM
Subject: Re: [TintBrowser] Some downloads corrupted (#2)

Hi,

I don't know what download you're talking about... I only put downloads here on GitHub and on the Android Market (now Google Play Store). If peoples put downloads on others locations, i'm not responsible for it. Can you give me some example of these downloads ?


Reply to this email directly or view it on GitHub:
#2 (comment)

@ntninja
Copy link

ntninja commented Jun 2, 2013

I hope this still gets read...
This issue happend to me several times too and I think I found the problem: Unlike the default browser, TintBrowser does not pass the Cookie List/Jar/whatever (I don't know the exact Android terminology of it) to the Android download manager. Many sites (shared file hosters, Moodle, ...) use this information so they can verify that you are authorized to start a certain download.

ntninja pushed a commit to ntninja/TintBrowser that referenced this issue Jun 2, 2013
 - Do correct Content-Disposition handling

IMPORTANT: These changes were not tested! I gave up making Eclipse compile the project after ~3h of downloading, installing, head-banging, screaming, cursing...
@ntninja ntninja mentioned this issue Jun 2, 2013
@Anasthase
Copy link
Owner

Yes, this is still read, even if i have less time to work on Tint.

Your code does not compile, so i can't accept your pull request as is, but i see what you're trying to do. I'll try to make it work when i find some time.

Many thanks anyway to spend time on this, your analysis of the problem seems right :)

@ElementW ElementW mentioned this issue Jun 3, 2013
@ntninja
Copy link

ntninja commented Jun 4, 2013

I guess gravgun has the better patch... I just had mine fixed up, but his is a little simpler (implementing this feature) and does just about the same.

@XRevan86
Copy link

XRevan86 commented Aug 4, 2013

@Alexander255 Hmm… why then @Anasthase doesn't accept pull request even for now?

@Anasthase
Copy link
Owner

Resolved by gravgun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants