Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

personal note text window does not scroll downward when keyboard is active. #230

Closed
tuomas2 opened this issue Jan 22, 2019 · 10 comments
Closed

Comments

@tuomas2
Copy link
Contributor

tuomas2 commented Jan 22, 2019

When entering text in a personal note for a verse (using the My Note feature), the text does not scroll. Or rather, it scrolls up if you type enough text, but then you can't scroll down in order to see the beginning of the text.

@tuomas2
Copy link
Contributor Author

tuomas2 commented Jan 22, 2019

Now the text is scrollable. Scrollbar still not visible. I'll leave this as I'm planning to re-organize "My notes" in the future (#188).

@tuomas2 tuomas2 closed this as completed Jan 22, 2019
@bvahedy
Copy link

bvahedy commented Jan 22, 2019

Ok, I was able to reproduce this. This does not happen when the keyboard is minimized. Once the keyboard is up you can't scroll the note text. For now you can minimized the keyboard and tap where you want to edit and that brings up the keyboard and starts where you tapped to edit text.

@tuomas2 tuomas2 reopened this Jan 22, 2019
@bvahedy bvahedy changed the title Scrollbar missing for personal note text personal note text window does not scroll downward when keyboard is active. Jan 24, 2019
@bvahedy
Copy link

bvahedy commented Jan 24, 2019

I'm relableing this to be more clear, I also bumped down it's priority since the user can still function by minimizing the keyboard and moving to where they want to make the change.

@bvahedy bvahedy reopened this Jan 24, 2019
@tuomas2 tuomas2 assigned tuomas2 and unassigned tuomas2 Jan 28, 2019
@bvahedy
Copy link

bvahedy commented Feb 14, 2019

This bug was fixed but now it's back.

@bvahedy bvahedy reopened this Feb 14, 2019
tuomas2 added a commit that referenced this issue Feb 15, 2019
@tuomas2
Copy link
Contributor Author

tuomas2 commented Feb 15, 2019

Will be fixed in 298

@tuomas2 tuomas2 assigned bvahedy and unassigned tuomas2 Feb 15, 2019
@tuomas2 tuomas2 closed this as completed Feb 15, 2019
@bvahedy bvahedy reopened this Feb 15, 2019
@bvahedy
Copy link

bvahedy commented Feb 15, 2019

We are getting closer, but still not able to scroll when keyboard is active. So, I'm reopening this ticket.

@bvahedy bvahedy assigned tuomas2 and unassigned bvahedy Feb 15, 2019
@tuomas2
Copy link
Contributor Author

tuomas2 commented Feb 16, 2019

From play beta feedback:

Issue #230 .. the cursor changes location when scrolled out of view. It should remain where it is until the user changes it. If a word is selected, it behaves correctly.

@bvahedy
Copy link

bvahedy commented Feb 16, 2019

I think this is related to the scroll issue. When trying to slide up is where it changes the curser position.

@tuomas2
Copy link
Contributor Author

tuomas2 commented Feb 18, 2019

From user via email:

► The cursor changes location when scrolled out of view. It should remain where it is until the user changes it. If a word is selected, the cursor (selection) behaves correctly. To reproduce: notes that are long enough to scroll when the keyboard is hidden.

► Scrolling is broken when the keyboard is visible .. for notes that are too short to scroll when the keyboard is hidden, but long enough to scroll when the keyboard is visible.

@tuomas2 tuomas2 modified the milestones: v3.1, v3.2 Feb 20, 2019
@tuomas2 tuomas2 removed this from the v3.2 milestone Feb 28, 2019
@tuomas2 tuomas2 removed their assignment Mar 1, 2019
@timbze
Copy link
Contributor

timbze commented Aug 4, 2021

Obsolete in 4.0

@timbze timbze closed this as completed Aug 4, 2021
@github-actions github-actions bot added this to Needs triage in Ben's project board Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants