Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a bookmark from my notes menu jumps to my notes... #241

Closed
bvahedy opened this issue Jan 26, 2019 · 4 comments
Closed

Selecting a bookmark from my notes menu jumps to my notes... #241

bvahedy opened this issue Jan 26, 2019 · 4 comments

Comments

@bvahedy
Copy link

bvahedy commented Jan 26, 2019

What happens:

  1. From a Bible tap on menu and select m my notes.
  2. select a note
  3. tap on the top left menu icon
  4. select bookmarks
  5. you are brought back to the my note screen.

Expected behavior:
When you are in the private note window, tapping on menu bar and selecting bookmarks brings up bookmarks. From there selecting a bookmark should take you to that passage in the Bible window.

@tuomas2
Copy link
Contributor

tuomas2 commented Jan 26, 2019

Confirmed

@bvahedy bvahedy changed the title Selection a bookmark from my notes menu jumps to my notes... Selecting a bookmark from my notes menu jumps to my notes... Jan 26, 2019
@tuomas2 tuomas2 self-assigned this Jan 28, 2019
@tuomas2
Copy link
Contributor

tuomas2 commented Jan 28, 2019

Should bible chapter/verse selector also get to the bible book rather than (empty) my notes entry?

@bvahedy
Copy link
Author

bvahedy commented Jan 28, 2019 via email

@tuomas2
Copy link
Contributor

tuomas2 commented Jan 28, 2019

Yes. The reader needs to see the verse before making any notes. We can assume they want to go to that chapter/verse rather than trying to make a note for it.

Re-opening for this.

@tuomas2 tuomas2 reopened this Jan 28, 2019
tuomas2 added a commit that referenced this issue Jan 31, 2019
@tuomas2 tuomas2 closed this as completed Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants