Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date-based reading plan #292

Closed
tuomas2 opened this issue Feb 9, 2019 · 16 comments · Fixed by #445
Closed

Date-based reading plan #292

tuomas2 opened this issue Feb 9, 2019 · 16 comments · Fixed by #445

Comments

@tuomas2
Copy link
Contributor

tuomas2 commented Feb 9, 2019

From user via email:

The current Reading Plan feature is based on whichever day you start a plan and progress through a plan. However, we would really like to see the option for date based plans (i.e. the readings for the 9th February are:...). This would allow for the use of several very common readings plans and for friends to be able to read & discuss the same sections on the same day.
I and several of my friends go to another app for the daily readings, but it would be great if it could all be done within this app. Please feel free to talk to me more about this feature, as we've wanted it for years and would be really keen to see it implemented.

@tuomas2
Copy link
Contributor Author

tuomas2 commented Feb 9, 2019

Assigned @timbze for you, if you want to consider implementing this feature request.

@timbze
Copy link
Contributor

timbze commented Feb 9, 2019

I think it is a good idea to have that option as well. And the idea came at the right time too :)

@tcressy
Copy link

tcressy commented Feb 9, 2019

I'm the user that Tuomas is quoting above. I have a quite a few friends around the world who use And Bible, but go to other apps that use a date based reading system (have the plan we use in them already). It would be great if date based plans were an option. It wouldn't matter if you either implemented the specific plan that we use, or just allowed a way for us to add our own date based plans our-self (a more flexible approach).

To be specific, the reading's plan we use (Christadelphian plan created by Robert Roberts ~150 years ago and widely used) can be found in many places, for example: https://www.dailyreadings.org.uk/default.asp?act=monthdisplay&m=1
Here's a link to my google sheet, where the plan can be copied nicely as a table.
https://docs.google.com/spreadsheets/d/1GdEf4my3gc2vZ1KJNWm1VrdeELvmzDaMelu6DNNuqJg/edit?usp=sharing

It would be great if date based plans were an option - thanks for considering this!

@timbze
Copy link
Contributor

timbze commented Feb 9, 2019

@tcressy Thank you for the additional information! Lord willing I will work on this feature together with an entire revamp to the reading plan feature in AndBible within a few weeks.

@tcressy
Copy link

tcressy commented Feb 20, 2019

@timbze No pressure, I was just wondering if there was any progress with the reworking of the reading plans? Many thanks.

@timbze
Copy link
Contributor

timbze commented Feb 20, 2019

Yes I have been working on it. I'm not finish outlining it here #284 but that's where I will put my outline and keep track of the progress. I have already done some coding, but it's quite the project, since we wanted to do a complete reworking of how the Reading Plans operates. Also, I have been using more Java program language before, and the project is switching to Kotlin, so it takes some time to learn and get used to as well. Thanks for your patience. I think I want to see this done as much as you :) but I work with the time I have...

@tuomas2
Copy link
Contributor Author

tuomas2 commented Feb 20, 2019

I think I want to see this done as much as you :)

I guess this is the best motivator ;) Have fun with hacking!

@tcressy
Copy link

tcressy commented Mar 21, 2019

@timbze Morning :) I hope you don't mind me asking again if there's been any progress with the date based readings plans? I might be a little bit too much of an ambassador for AndBible, but I know there are quite a few of us who are in eager anticipation... :)
Many thanks for all of your work.

@tuomas2
Copy link
Contributor Author

tuomas2 commented Mar 21, 2019

@timbze Morning :) I hope you don't mind me asking again if there's been any progress with the date based readings plans? I might be a little bit too much of an ambassador for AndBible, but I know there are quite a few of us who are in eager anticipation... :)
Many thanks for all of your work.

My opinion is that we should not give time estimates to users, simply to avoid unnecessary pressure to the developers. We will let users know when new stuff is ready for beta and when they are, users can then help in improving the quality by reporting good bug tickets. Until that, this kind of questions should be relevant only if you are planning to work yourself on this or related feature.

@tcressy
Copy link

tcressy commented Mar 21, 2019

@timbze Morning :) I hope you don't mind me asking again if there's been any progress with the date based readings plans? I might be a little bit too much of an ambassador for AndBible, but I know there are quite a few of us who are in eager anticipation... :)
Many thanks for all of your work.

My opinion is that we should not give time estimates to users, simply to avoid unnecessary pressure to the developers. We will let users know when new stuff is ready for beta and when they are, users can then help in improving the quality by reporting good bug tickets. Until that, this kind of questions should be relevant only if you are planning to work yourself on this or related feature.

My apologies - sadly I don't have the skills to work on it. I'll leave you to it and won't pester again.

@timbze
Copy link
Contributor

timbze commented Mar 21, 2019

@tcressy Not a problem. I can tell you there has been progress, but doing this as a spare time project, and also being busy with other things in life makes it take time. Thanks for your understanding.

timbze added a commit to timbze/and-bible that referenced this issue Mar 24, 2019
…nd sharedPrefs. Support for Date-based plans. Addresses AndBible#55, AndBible#292, AndBible#283, and partially AndBible#180 (not quite good yet, need more options to delete plan and also edit plan name/description. Also need to be able to select the plan file from device instead of just looking at one folder).
tuomas2 added a commit that referenced this issue Nov 21, 2019
@tuomas2
Copy link
Contributor Author

tuomas2 commented Nov 21, 2019

Implemented in build 319.0

@bvahedy
Copy link

bvahedy commented Nov 22, 2019 via email

@tuomas2
Copy link
Contributor Author

tuomas2 commented Nov 22, 2019

@timbze knows better :-)

@timbze
Copy link
Contributor

timbze commented Nov 22, 2019

@bvahedy You can test date-based reading plan with this file. Just add it to the folder for custom reading plans. You must change the file extension to .properties

@bvahedy bvahedy removed their assignment Nov 23, 2019
@bvahedy
Copy link

bvahedy commented Nov 23, 2019

Verified fix working in beta 319.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants