Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More flexible bookmark labels #638

Closed
JJK96 opened this issue Apr 30, 2020 · 3 comments
Closed

More flexible bookmark labels #638

JJK96 opened this issue Apr 30, 2020 · 3 comments
Labels
Bookmarks Prio: Minor Status: Preliminary Type: Feature
Milestone
v4.0

Comments

@JJK96
Copy link
Contributor

JJK96 commented Apr 30, 2020

There are currently only 5 bookmark styles of which only 4 are colors. I would like to use more colors for my bookmarks.

Describe the solution you'd like

A first step would be adding more colors to the styles.
A better solution would be to have the user choose an arbitrary color for a bookmark label.
@tuomas2 tuomas2 added this to the v3.4 milestone May 1, 2020
@tuomas2
Copy link
Contributor

tuomas2 commented May 1, 2020

I have plans to improve bookmarks in many ways (some documented in tickets, some not) after 3.3, and it is priority to me as well. If you want to do the first step quick fix it's fine, but there will be bigger revamp to bookmarks coming later for sure.

See #189 #111 #430 etc...

JJK96 added a commit to JJK96/and-bible that referenced this issue May 9, 2020
@JJK96
Add new bookmark styles
e822b1c 
Orange, purple and underline.
Fix AndBible#66, Ref AndBible#638
@JJK96 JJK96 mentioned this issue May 9, 2020
Merged
@tuomas2 tuomas2 removed their assignment May 11, 2020
@tuomas2
Copy link
Contributor

tuomas2 commented Sep 8, 2020

Via support (https://support.andbible.org/scp/tickets.php?id=83)

May I add another idea too.. being able to Verse marking (and/or underlining) in different colours would be another "bon bon" (candy).. but surely not urgent.

@tuomas2
Copy link
Contributor

tuomas2 commented Feb 13, 2021

Implemented in develop

@tuomas2 tuomas2 closed this as completed Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bookmarks Prio: Minor Status: Preliminary Type: Feature
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
2 participants
@tuomas2 @JJK96