Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move variables to correct replace file #23

Merged
merged 3 commits into from
Mar 17, 2024

Conversation

trym-b
Copy link
Collaborator

@trym-b trym-b commented Mar 17, 2024

Best reviewed commit by commit

This commit solves the following error:

```
[pdx_localize.cpp:197]: Duplicate localization
key. Key 'region_dnieper' is defined in both
'localization/english/br_misc_l_english.yml' and
'localization/english/map/
strategic_regions_l_english.yml'.
```

The fix is to move the variable into a `replace`
directory file.
`br_names_l_english.yml` now has consistent
indentation.
This commit solves the following error:

```
[pdx_localize.cpp:197]: Duplicate localization
key. Key 'Xochitl' is defined in both
'localization/english/br_names_l_english.yml' and
'localization/english/names_l_english.yml'.
```

The fix is to move the variable into a `replace`
directory file.
@AndHope AndHope merged commit c410ce2 into main Mar 17, 2024
1 check passed
@AndHope AndHope deleted the refactor/move-variables-to-correct-replace-file branch March 17, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants