fix: various errors #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit solves errors such as: ``` [modifier_types.cpp:473]: Modifier is missing loc key! Modifier: goods_input_canalToll_add, LocKey: modifier_goods_input_canalToll_add [modifier_types.cpp:482]: Modifier is missing description loc key! Modifier: goods_input_canalToll_add, LocKey: modifier_goods_input_canalToll_add_desc ``` This is fixed by adding the localization keys in the appropriate file.
This commit solves the following error: ``` [pdx_persistent_reader.cpp:252]: Error: "Unexpected token: goods_output_passenger_transportation_add, near line: 59" in file: "common/production_methods/br_urban_center_production_method.txt" near line: 59 ```
This commit solves errors such as: ``` [eventtargetlinks.cpp:3368]: Failed to find country! Country: PBC, File Location: file: common/character_templates/country_bol.txt line: 93 ``` This is solved by overwriting vanilla files.
|
Good stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit by commit