refactor: add vanilla tech tree #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation To prepare for adding a pre-1836 tech tree, the technologies that are used implicitly by the mod should be explicitly added. This will make it easier to see what changes are added when new technologies are added. # Changes Vanilla technologies in `10_production.txt`, `20_military.txt` and `30_society.txt` are simply overwritten. This is to avoid later upstream changes breaks the mod. This change also fixes the following error: ``` [jomini_script_system.cpp:262]: Script system error! Error: has_journal_entry trigger [ Invalid database object 'je_risorgimento' ] Script location: file: common/technology/technologies/30_society.txt line: 668 ``` # Future work * Incorporate add new eras (1736-1836) * Incorporate the existing new technologies `track` etc, properly into this new structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To prepare for adding a pre-1836 tech tree, the
technologies that are used implicitly by the mod
should be explicitly added. This will make it
easier to see what changes are added when new
technologies are added.
Changes
Vanilla technologies in
10_production.txt,20_military.txtand30_society.txtare simplyoverwritten. This is to avoid later upstream
changes breaks the mod.
This change also fixes the following error:
Future work
tracketc, properly into this new structure