Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError in version 8.4.1 #368

Closed
emmenko opened this issue Mar 22, 2023 · 5 comments · Fixed by #370
Closed

TypeError in version 8.4.1 #368

emmenko opened this issue Mar 22, 2023 · 5 comments · Fixed by #370

Comments

@emmenko
Copy link
Contributor

emmenko commented Mar 22, 2023

image

Updating from version 8.4.0 to 8.4.1 causes an error in our tests. Maybe related to the changes in #362 ?

cc @ArnaudRinquin
@Andarist
Copy link
Owner

Yes, it's likely related. JSDom doesn't implement document.fonts - that alone I don't classify as a problem. The runtime code of the library doesn't have to support JSDom quirks. However, the README currently states that:

This module supports IE9 and above.

And document.fonts is not available in IE. So I would accept a PR fixing this.

@soulakmartin
Copy link

soulakmartin commented Mar 24, 2023 •
edited

+1

I have same issue.

@jiahaoyu6666 jiahaoyu6666 mentioned this issue Mar 31, 2023
Merged
justinlittman added a commit to LD4P/sinopia_editor that referenced this issue Apr 3, 2023
@justinlittman
Pin react-textarea-autoresize due to Andarist/react-textarea-autosize…
dca5b0f 
…#368
@diox diox mentioned this issue Apr 7, 2023
Closed
ArnaudRinquin added a commit to ArnaudRinquin/react-textarea-autosize that referenced this issue Apr 14, 2023
@ArnaudRinquin
Handle document.fonts not being define
cdfaa18 
fixes Andarist#368
@ArnaudRinquin ArnaudRinquin mentioned this issue Apr 14, 2023
Merged
ArnaudRinquin added a commit to ArnaudRinquin/react-textarea-autosize that referenced this issue Apr 14, 2023
@ArnaudRinquin
Handle document.fonts not being define
50b9a64 
fixes Andarist#368
ArnaudRinquin added a commit to ArnaudRinquin/react-textarea-autosize that referenced this issue Apr 14, 2023
@ArnaudRinquin
Handle document.fonts not being define
2325064 
fixes Andarist#368
ArnaudRinquin added a commit to ArnaudRinquin/react-textarea-autosize that referenced this issue Apr 14, 2023
@ArnaudRinquin
Handle document.fonts not being define
2882c1c 
fixes Andarist#368
@ArnaudRinquin
Copy link
Contributor

Sorry folks, only noticed this issue now. Proposed something that should fix this.

@billdwhite
Copy link

+1 same issue here

baiirun added a commit to geobrowser/geogenesis that referenced this issue May 19, 2023
@baiirun
revert react-textarea-autosize to 8.4.0
73f09ef 
There are type errors in 8.4.1. See Andarist/react-textarea-autosize#368
@baiirun baiirun mentioned this issue May 19, 2023
Merged
baiirun added a commit to geobrowser/geogenesis that referenced this issue May 19, 2023
@baiirun
feat: table block space filter option (#331)
342ad7c 
* naive implementation of space filter

* refactor table block components into separate files

* fix initial loading state for tables

* create space-specific input search

* use startsWith for local space filtering

* Animate in Done button when filter is ready to be created

* debounce space filtering

* fix name input field

* add query generation and parsing tests for space filter

* extra context

* fixes after master merged in

* move complex filter prompt state to reducer

* filter out non string/relation entity type columns

* revert react-textarea-autosize to 8.4.0

There are type errors in 8.4.1. See Andarist/react-textarea-autosize#368

* pin to 8.4.0
baiirun added a commit to geobrowser/geogenesis that referenced this issue May 22, 2023
@baiirun
feat: use accessible colors for table error fallback (#335)
142cc7b 
* naive implementation of space filter

* refactor table block components into separate files

* fix initial loading state for tables

* create space-specific input search

* use startsWith for local space filtering

* Animate in Done button when filter is ready to be created

* debounce space filtering

* fix name input field

* add query generation and parsing tests for space filter

* extra context

* fixes after master merged in

* move complex filter prompt state to reducer

* filter out non string/relation entity type columns

* revert react-textarea-autosize to 8.4.0

There are type errors in 8.4.1. See Andarist/react-textarea-autosize#368

* pin to 8.4.0

* fix: add fallback error state to table block

* update colors

update colors

* no error boundary in table block component

* move error handling into provider for table block

* fix new selected type types

* feat: use more accessible colors for table error text
@oleh-demkovych
Copy link

A temporary solution is to mock document.fonts in jest:

Object.defineProperty(document, 'fonts', {
  value: { addEventListener() {}, removeEventListener() {} },
});

Andarist added a commit that referenced this issue Jun 21, 2023
@ArnaudRinquin @Andarist
Add a guard against potentially missing documents.fonts (#370)
d33b120 
* Handle document.fonts not being define

fixes #368

* Update .changeset/great-moose-judge.md

---------

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle document.fonts not being defined (IE9) ArnaudRinquin/react-textarea-autosize
6 participants
@ArnaudRinquin @billdwhite @emmenko @Andarist @soulakmartin @oleh-demkovych