Add some themes #20
Merged
Add some themes #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnderGoig
requested changes
Feb 11, 2024
There was a problem hiding this comment.
Hey @hyphen-o, awesome contribution! Thank you so much and sorry for the delay reviewing this.
I love the inverted theme and the yellow one looks amazing on dark mode.
However, when I switch to light mode, the yellow one looks a bit too light. Perhaps a bit more yellowish color, or darker yellow would work? what do you think? 🤔
GitHubContributionsWidget/es.lproj/GitHubContributionsWidget.strings
Outdated
Show resolved
Hide resolved
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make this app more colorful I implemented adding "yellow" and "invert" themes. Invert means white for the light theme and black for the dark theme.
This is my first implementation with Swift,so please close this PR if this does not work as you expect😅
Thanks for a great app!